Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prediction path explanation should show comparisons in order of node discovery #204

Closed
parrt opened this issue Dec 10, 2022 · 5 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@parrt
Copy link
Owner

parrt commented Dec 10, 2022

Currently the output for the prediction path is given in the feature order in the data frame.

@parrt parrt added the enhancement New feature or request label Dec 10, 2022
@parrt parrt added this to the 2.0 milestone Dec 10, 2022
@parrt parrt removed this from the 2.0 milestone Dec 11, 2022
@mepland
Copy link
Collaborator

mepland commented Jan 3, 2023

Do we want to only display the features used in the prediction? I think the user can print a dataframe row if they want all of the features, but including them is making the text box large, or adding the ellipsis.

dtreeviz_pred_path

@tlapusan
Copy link
Collaborator

tlapusan commented Jan 3, 2023

@mepland I think that @parrt is referring to this viz
Screenshot 2023-01-03 at 09 58 47

@mepland
Copy link
Collaborator

mepland commented Jan 4, 2023

@parrt @tlapusan done, see #234

@parrt
Copy link
Owner Author

parrt commented Jan 5, 2023

Regarding showing the entire instance of X, probably best to show at all but I can see a case where it's too big. Sometimes knowing what the other variables are even if they are not tested is useful.

@parrt
Copy link
Owner Author

parrt commented Jan 8, 2023

Closing per our discussion #234 (comment)

@parrt parrt closed this as completed Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants