From 13648b4038d7c1703ccf35a3cc5c7453cf879575 Mon Sep 17 00:00:00 2001 From: Agnieszka Gawrys Date: Wed, 18 Oct 2023 12:28:59 -0700 Subject: [PATCH 1/2] forgot to readd in uniquekey --- packages/bundlers/default/src/DefaultBundler.js | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/bundlers/default/src/DefaultBundler.js b/packages/bundlers/default/src/DefaultBundler.js index dac4686bfff..3209c023fa0 100644 --- a/packages/bundlers/default/src/DefaultBundler.js +++ b/packages/bundlers/default/src/DefaultBundler.js @@ -776,6 +776,7 @@ function createIdealGraph( manualSharedMap.set(manualSharedBundleKey, bundleId); } bundle.manualSharedBundle = manualSharedObject.name; + bundle.uniqueKey = manualSharedObject.name + childAsset.type; } } } From 5f6c220b246e6898e59a41441b636dc5f9a66dbb Mon Sep 17 00:00:00 2001 From: Agnieszka Gawrys Date: Wed, 18 Oct 2023 13:16:40 -0700 Subject: [PATCH 2/2] add tests --- packages/core/integration-tests/test/bundler.js | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/packages/core/integration-tests/test/bundler.js b/packages/core/integration-tests/test/bundler.js index eeb3d1d362a..a98dd5f5b03 100644 --- a/packages/core/integration-tests/test/bundler.js +++ b/packages/core/integration-tests/test/bundler.js @@ -9,6 +9,7 @@ import { fsFixture, run, } from '@parcel/test-utils'; +import {hashString} from '@parcel/rust'; describe('bundler', function () { it('should not create shared bundles when a bundle is being reused and disableSharedBundles is enabled', async function () { @@ -1520,6 +1521,10 @@ describe('bundler', function () { assets: ['math.js', 'add.js', 'subtract.js'], }, ]); + + let targetDistDir = __dirname.replace('/test', '/dist'); + let hashedIdWithMSB = hashString('bundle:' + 'vendorjs' + targetDistDir); + assert(b.getBundles().find(b => b.id == hashedIdWithMSB)); }); it('should support manual shared bundles with constants module', async function () { @@ -1655,6 +1660,10 @@ describe('bundler', function () { }, ]); + let targetDistDir = __dirname.replace('/test', '/dist'); + let hashedIdWithMSB = hashString('bundle:' + 'vendorjs' + targetDistDir); + assert(b.getBundles().find(b => b.id == hashedIdWithMSB)); + await run(b); });