Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #59419

Closed
wants to merge 3 commits into from

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Aug 5, 2024

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.5.0 → v0.5.6](astral-sh/ruff-pre-commit@v0.5.0...v0.5.6)
- [github.com/asottile/pyupgrade: v3.16.0 → v3.17.0](asottile/pyupgrade@v3.16.0...v3.17.0)
@rhshadrach
Copy link
Member

@mroeschke - locally I'm seeing pyright 1.1.374 not report any errors regarding this change, but pinned to 1.1.352 gives error: "Generator" expects 3 type arguments, but 1 given. However I get other errors/warnings on 1.1.374 too.

@mroeschke
Copy link
Member

OK given the inconsistency in pyright with maybe another package, let's just skip this pre-commit update for now. We can revisit this in next month's update

@mroeschke mroeschke closed this Aug 6, 2024
@mroeschke mroeschke deleted the pre-commit-ci-update-config branch August 6, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants