From ba17b28e68842c2eb770d8fdfc5714a355421c3c Mon Sep 17 00:00:00 2001 From: tp Date: Tue, 7 Jul 2020 08:14:58 +0100 Subject: [PATCH] more typing --- pandas/core/indexes/base.py | 7 ++++++- pandas/core/indexes/datetimelike.py | 10 +++++++--- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/pandas/core/indexes/base.py b/pandas/core/indexes/base.py index b5d270603acdfb..3dbee7d0929cbc 100644 --- a/pandas/core/indexes/base.py +++ b/pandas/core/indexes/base.py @@ -902,7 +902,12 @@ def _mpl_repr(self): # how to represent ourselves to matplotlib return self.values - def format(self, name: bool = False, formatter=None, na_rep="NaN") -> List[str_t]: + def format( + self, + name: bool = False, + formatter: Optional[Callable] = None, + na_rep: str_t = "NaN", + ) -> List[str_t]: """ Render a string representation of the Index. """ diff --git a/pandas/core/indexes/datetimelike.py b/pandas/core/indexes/datetimelike.py index e526bddb0fccbb..15a7e25238983d 100644 --- a/pandas/core/indexes/datetimelike.py +++ b/pandas/core/indexes/datetimelike.py @@ -9,7 +9,7 @@ from pandas._libs import NaT, Timedelta, iNaT, join as libjoin, lib from pandas._libs.tslibs import BaseOffset, Resolution, Tick, timezones from pandas._libs.tslibs.parsing import DateParseError -from pandas._typing import Label +from pandas._typing import Callable, Label from pandas.compat.numpy import function as nv from pandas.errors import AbstractMethodError from pandas.util._decorators import Appender, cache_readonly, doc @@ -339,7 +339,11 @@ def argmax(self, axis=None, skipna=True, *args, **kwargs): # Rendering Methods def format( - self, name: bool = False, formatter=None, na_rep="NaT", date_format=None + self, + name: bool = False, + formatter: Optional[Callable] = None, + na_rep: str = "NaT", + date_format: Optional[str] = None, ) -> List[str]: """ Render a string representation of the Index. @@ -352,7 +356,7 @@ def format( if formatter is not None: return header + list(self.map(formatter)) - return self._format_with_header(header, date_format=date_format, na_rep=na_rep) + return self._format_with_header(header, na_rep=na_rep, date_format=date_format) def _format_with_header(self, header, na_rep="NaT", date_format=None) -> List[str]: return header + list(