Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poll instance list #2377

Closed
david-crespo opened this issue Aug 16, 2024 · 0 comments · Fixed by #2391
Closed

Poll instance list #2377

david-crespo opened this issue Aug 16, 2024 · 0 comments · Fixed by #2391
Assignees
Milestone

Comments

@david-crespo
Copy link
Collaborator

I ended up leaving this out of #2360 because I felt it was a little aggressive to always poll if any instance on the current page is in a transitional state. However, after you see auto-polling on the instance detail page, it feels like a big lack on the instance list, particularly when you start or stop an instance from that page. It changes to stopping and then sits there, which feels quite useless.

image

Because #2360 established a visual indicator that we are polling on instance detail (spinner next to the state badge), I feel more comfortable being clever in our logic around when to poll. Some ways it could work (not mutually exclusive):

  • Poll for up to N seconds after an action if any instance in scope is transitioning
  • Poll for up to N seconds after initial pageload if any instance in scope is transitioning
  • Increase polling interval after a certain amount of time polling

See also #2376 for fancier polling logic on instance detail.

@david-crespo david-crespo added this to the 10 milestone Aug 19, 2024
@david-crespo david-crespo self-assigned this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant