Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private link does not open in default app #9799

Closed
tbsbdr opened this issue Oct 12, 2023 · 4 comments · Fixed by #9821
Closed

Private link does not open in default app #9799

tbsbdr opened this issue Oct 12, 2023 · 4 comments · Fixed by #9821
Assignees
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working

Comments

@tbsbdr
Copy link
Contributor

tbsbdr commented Oct 12, 2023

Steps to reproduce

  1. Create for-Albert.docx and create a private link "Only invite ppl can view"
  2. send the link via email to albert
  3. Albert accepts the share
  4. Albert clicks on the link in the email
  5. Private Link does not open in default app

Expected behaviour

  • The private link should open in the default app (eg. Collabora - same behaviour as for public links)

Actual behaviour

  • Private Link does not open in default app
@tbsbdr tbsbdr added the Type:Bug Something isn't working label Oct 12, 2023
@tbsbdr
Copy link
Contributor Author

tbsbdr commented Oct 12, 2023

Labeling as bug as enduser experienced it as "broken". debatable, but I decided to take the enduser perspective. (also shows that the public link experience is quite well received)

@tbsbdr
Copy link
Contributor Author

tbsbdr commented Oct 12, 2023

@JammingBen wondering if there will occur any unwanted sideeffects if we change the behaviour of the private link to the behaviour of the public link. seeing the file-tree (location of the shared file) will still be possible if you select X-Close in the file control bar. so that should still work out...

@tbsbdr tbsbdr added the Priority:p2-high Escalation, on top of current planning, release blocker label Oct 12, 2023
@JammingBen JammingBen self-assigned this Oct 13, 2023
@JammingBen
Copy link
Collaborator

JammingBen commented Oct 17, 2023

@tbsbdr Turns out this is a bit messy as it is currently... Internal and public links behave differently when it comes to opening files. When solving this issue, private links will resolve into the default app, whereas public links resolve into the file list and highlight the file. Should we align this and always resolve into the default app? Or is the different behaviour intended?

@tbsbdr
Copy link
Contributor Author

tbsbdr commented Oct 18, 2023

yes, we should resolve into the default app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working
Projects
Archived in project
Status: In progress
Development

Successfully merging a pull request may close this issue.

2 participants