Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce ClickOutside directive #7572

Closed
lookacat opened this issue Sep 1, 2022 · 2 comments · Fixed by #7584
Closed

Reintroduce ClickOutside directive #7572

lookacat opened this issue Sep 1, 2022 · 2 comments · Fixed by #7584

Comments

@lookacat
Copy link
Contributor

lookacat commented Sep 1, 2022

We noticed the clickOutside.js directive accidentally got removed from the right sidebar.

Expected behaviour

Right sidebar gets closed on click outside (e.g. files-table)

Actual behaviour

Nothing happens

@tbsbdr
Copy link
Contributor

tbsbdr commented Sep 5, 2022

hey @lookacat I doubt that this is expected behaviour. Have you seen this behaviour (right sidebar closes on outside-click) in any other browser-based fileexplorer so that I could have a look?

@kulmann
Copy link
Member

kulmann commented Sep 5, 2022

I'm also fine not having it at all. but then I'd like to get rid of the dead code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants