Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename: Prevent accidental change of the file extension #6729

Closed
tbsbdr opened this issue Apr 4, 2022 · 1 comment · Fixed by #6736
Closed

Rename: Prevent accidental change of the file extension #6729

tbsbdr opened this issue Apr 4, 2022 · 1 comment · Fixed by #6736
Assignees

Comments

@tbsbdr
Copy link
Contributor

tbsbdr commented Apr 4, 2022

Steps to reproduce

  1. go to new design in https://web.owncloud.com/
  2. select ownCloud Manual.pdf and choose "rename"
  3. type "asd"
  4. hit enter

Expected behaviour

file is renamed to asd.pdf and can still be opened via rightclick -> open with pdf viewer

Actual behaviour

file is renamed to asd and can not be opened with the pdf viewer

initial text-selection guides the user towards changing the file extension
image

Remedy

On rename, only the filename without extension should be pre text-selected
image

@phil-davis
Copy link
Contributor

phil-davis commented Apr 5, 2022

Note: the existing behavior of the oC10 classic webUI" is the same as the "Remedy" expected behavior here. So this issue will make web behave the same as the classic webUI.

It would be nice to have a test somewhere that checks this behavior - the rename test should type directly into the filed without clearing it, and verify that the file extension is preserved. Hopefully that is easy/possible with playwright.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants