Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activities. Wrong activity log when public changes file content #9676

Closed
Tracked by #9683
ScharfViktor opened this issue Jul 23, 2024 · 3 comments · Fixed by #10116
Closed
Tracked by #9683

Activities. Wrong activity log when public changes file content #9676

ScharfViktor opened this issue Jul 23, 2024 · 3 comments · Fixed by #10116
Assignees
Labels

Comments

@ScharfViktor
Copy link
Contributor

Steps:

  1. admin creates a public link for a file with edit permissions
  2. public or authorized user opens file and edits content
  3. admin sees activities

Expected: something like: public added content or einstein added forPublic.odt using public link

Actual: admin added forPublic.odt to Admin - wrong activity log. It was public (not admin)

Screen.Recording.2024-07-23.at.12.44.26.mov
@kobergj
Copy link
Collaborator

kobergj commented Sep 18, 2024

@ScharfViktor I can't reproduce this. What I see is DeletedUser added forPublic.odt to Admin.

The DeletedUser string comes from the backend (hardcoded). I could change that to Anonymous that would fit both deleted and public case.

Or do we need a more advanced logic for that?

@kobergj kobergj self-assigned this Sep 18, 2024
@ScharfViktor
Copy link
Contributor Author

@ScharfViktor I can't reproduce this. What I see is DeletedUser added forPublic.odt to Admin.

re-tested. is still reproducing:
image

admin instead of public

@kobergj
Copy link
Collaborator

kobergj commented Sep 18, 2024

It's different in personal and project spaces. I'll check why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants