Search user by full name doesn't work

[ScharfViktor]

web 4.9.0
ocis(docker) 1.16.0

Steps:

• Admin add file
• go to share dialog
• add to invite input "Marie Curie"

Actual result: user not found

Search by mail or name - works

[rhafer]

This seems to be a problem in glauth (or the accounts backend of glauth). Apparently filtering on "displayName" (the attribute that contains the full name does not work:

Doing the search manually gives no result as well,

 ldapsearch -x -H ldap://127.0.0.1:9125 -b dc=ocis,dc=test -D "cn=admin,dc=ocis,dc=test" -w admin '(&(objectclass=posixaccount)(displayname=mar*))'
# extended LDIF
#
# LDAPv3
# base <dc=ocis,dc=test> with scope subtree
# filter: (&(objectclass=posixaccount)(displayname=mar*))
# requesting: ALL
#

# search result
search: 2
result: 0 Success

# numResponses: 1

I guess this issue will go away once we switch away from glauth

[rhafer]

Seems that this was working at least until v1.16.0. So I've tried to git bisect our code to find the point where it was introduced. It seems this is caused by one of the changes in the big "spaces registry" PR#2739. It seems that some of the changes in there (or on the reva side) broke the indexes for glauth. (Aparatently as soon as you try to filter for something where the actual attribute value is containing a space).

Unfortunately I could not track this down to a single commit as most of the intermediate commits don't produce any testable binary which I needed to skip during bisect 🤷‍♂️ . This is the closest list of commits that I could come up with:

There are only 'skip'ped commits left to test.
The first bad commit could be any of:
31bf29cb26944b3841c5845ac1b6eef484c8081b
5ec72daaeb512efbc83c62e13fc098f4f49ed5a0
550b0bbfeaa2790fa90062fbf230b5e5b3a6b853
de7620af98a2ec3fdd36bc90a83cd0597a3fb89b
c36e99895bbfd25b923455feb6b1c16f0f52e576
f9bfc27a82b9bcd068cb62966c96166772c442ce
321f5b8b46a0fca55ebea80b9cffe12d14637643
b63b322b6f0abfd2cb4e6a7f3359b6517e56f723
5a29959a0bfe26fa468101207c0343cd283f737f
b527702572cce19699f7a7138f23a827ac6c6f50
a3702f722da27e8a81526e0ac01f244ddfa6a0e1
Keine binäre Suche mehr möglich!

@kobergj @butonic Any ideas? (If this is affecting the accounts service only, I am not sure if we need to invest much time here as that is mostly likely going away at some point. Is the indexer code ocis-pkg/indexer only used by accounts or is it supposed to be some generic solution that we need to keep?

[ScharfViktor]

I re-tested it on ownCloud Web UI 5.5.0-rc.5 Infinite Scale 0.0.0+5526d6179 Community

search user by full name Marie Skłodowska Curie works.