Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity: folder variable missing if folder renamed #10148

Closed
Tracked by #9683
kulmann opened this issue Sep 24, 2024 · 1 comment · Fixed by #10152
Closed
Tracked by #9683

Activity: folder variable missing if folder renamed #10148

kulmann opened this issue Sep 24, 2024 · 1 comment · Fixed by #10152
Assignees
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug

Comments

@kulmann
Copy link
Member

kulmann commented Sep 24, 2024

Describe the bug

If I rename a folder, the activity events loose context, see screenshot.

Steps to reproduce

  1. Create a folder "test"
  2. Create a subfolder "subtest"
  3. Open the activities sidebar panel for "test"

Expected behavior

Old activity events still show the old folder name from before the rename

Actual behavior

The folder context is missing entirely (see screenshot)

Screenshot 2024-09-24 at 13 12 50
@kulmann kulmann added Type:Bug Priority:p2-high Escalation, on top of current planning, release blocker labels Sep 24, 2024
@2403905 2403905 self-assigned this Sep 24, 2024
@2403905
Copy link
Contributor

2403905 commented Sep 24, 2024

It happens because the old ref.Path that we keep in the event is not relevant for getting the resource information after renaming.
We can use the part of the path for that. But it will not work when the resource id has been used for renaming (MOVE)
FYI @kobergj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants