Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activities. no activity for public link change (role, expiration date, password) #10012

Closed
Tracked by #9683
butonic opened this issue Sep 9, 2024 · 3 comments · Fixed by #10085
Closed
Tracked by #9683

Activities. no activity for public link change (role, expiration date, password) #10012

butonic opened this issue Sep 9, 2024 · 3 comments · Fixed by #10085
Assignees
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug

Comments

@butonic
Copy link
Member

butonic commented Sep 9, 2024

Expected: it would be nice to know that public link was changed and who did it (in the space context)
Actual: no events

@butonic butonic changed the title Activities: no activity for public link change (role, expiration date, password) Activities. no activity for public link change (role, expiration date, password) Sep 9, 2024
@tbsbdr tbsbdr added the Priority:p2-high Escalation, on top of current planning, release blocker label Sep 9, 2024
@2403905 2403905 self-assigned this Sep 11, 2024
@2403905
Copy link
Contributor

2403905 commented Sep 12, 2024

We can recognize the change for the role, expiration date, and password in a eventsmiddelware. We could extend the events.LinkUpdated by the boolean field.

@2403905
Copy link
Contributor

2403905 commented Sep 17, 2024

I have tried to return the proper event for the public link update using the link.UpdatePublicShareResponse.Opaque as a carrier.
User updated the permission. User updated the password. User updated the expiration date.
I faced a few problems, the graph uses the PATH as a PUT no matter what parameter the user changed on UI.
Then graph calls updatePublicLink three times and the middleware emits three events...

@prashant-gurung899
Copy link
Contributor

@2403905 In personal space context, for public link change (role,expiration date, password) of a file there are no activities.
Should we reopen this issue or make another one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants