Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete shares from user when user is deleted #1226

Closed
PVince81 opened this issue Jul 8, 2020 · 6 comments
Closed

Delete shares from user when user is deleted #1226

PVince81 opened this issue Jul 8, 2020 · 6 comments
Labels
Interaction:Needs-help Asking some hints to engineering when the issue can't be reproduced Status:Stale

Comments

@PVince81
Copy link
Contributor

PVince81 commented Jul 8, 2020

See https://github.com/owncloud/ocis-reva/issues/262.

We need to remove the user's shares from shares.json and publicshares.json (which act like caches)

Might need some kind of notification system in reva where the deletion/disappearance of a user would propagate an event to all the storage providers so they can proceed to delete any user related metadata.

@butonic

@dpakach
Copy link
Contributor

dpakach commented Sep 16, 2020

Also, have the same problem with EOS. The shares are not deleted when the user is deleted. Even if we clear the shares.json file, the shares will reappear automatically. This means the shares are cached in memory somewhere and that rewrites the shares.json file when there is a new share. Probably the storage provider (EOS) doesn't knows when the users are deleted in OCIS. They need to communicate somehow.
cc @butonic

@phil-davis
Copy link
Contributor

phil-davis commented Sep 16, 2020

It will really help the automated test process if user-cleanup works well. In afterScenario of test scenarios we delete the users in order to give the next scenario a clean start.

Otherwise we could adjust the afterScenario of tests so that it first loops through and deletes each share that was created by the user in the scenario, then finally deletes the user. But that won't need to be done if this share cleanup issue is made to work.

@butonic butonic transferred this issue from owncloud/ocis-reva Jan 18, 2021
@refs refs added the Interaction:Needs-help Asking some hints to engineering when the issue can't be reproduced label Jan 18, 2021
@settings settings bot removed the p3-medium label Apr 7, 2021
@stale
Copy link

stale bot commented Jun 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status:Stale label Jun 6, 2021
@phil-davis
Copy link
Contributor

IMO we do not have any special code any more in the test suite for cleaning up shares when a user is deleted. It seems to work OK, at least with the "owncloud" and "ocis" storages that are in automated CI.

Maybe this has been all fixed?

@stale
Copy link

stale bot commented Aug 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status:Stale label Aug 6, 2021
@phil-davis
Copy link
Contributor

Closing as this is also covered by #1258 - I will check there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Interaction:Needs-help Asking some hints to engineering when the issue can't be reproduced Status:Stale
Projects
None yet
Development

No branches or pull requests

4 participants