-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE REQUEST] "Open in Web" for native clients #1127
Comments
|
If integration with external/add-on web services is something that should be available across clients, it could IMO make sense to have a dedicated ocis API for this that:
|
Default browser app, I'd say. Definitely not the in-app browser.
Yes, oCIS has the app provider for this. More information can be provided e.g., by @wkloucek |
Why not in-app browser (or as option)? I think it could be also interesting to do not lose the focus or to have it in a container app. |
It's described here: https://owncloud.dev/extensions/app-registry/apps. If you miss something I'll be happy to add that. |
We should also reuse the session. Don't know if there is a limitation in the integrated or default browser. |
Coming from a use case perspective, I think I'd find it rather weird to make some last minute changes in a presentation in the in-app browser. Having separate browser open feels somewhat more solid, I think. But maybe I just need to see it in action. |
Thanks, that looks good @wkloucek! One note on opening in an in-app browser vs. in Safari/Chrome/… however. Under
It's only possible to open simple URLs in Safari/Chrome/… on iOS. Which results in the browser using the It's not possible to open a URL in a browser using a The difference in user experience should be marginal. At least on iPadOS it would be possible to open it in a separate "scene" (think "window") that could be used side-by-side just like one could with two different apps. /cc @pmaier1 |
Ah ok, thanks. In that case I'd leave this up to you to decide. In-app browser seems like the way to go. |
Any update? cc @michaelstingl @dragotin |
@michaelstingl Ich schließ' mich der Frage an. What's the status and what can we show for the testing system? |
Backend update: owncloud/client#9724 (comment) |
App provider support is implemented by #1151, but I noticed a few rough edges in actual usage when using the open-in-web endpoint:
Possible remedies:
|
@kulmann could you check if that's possible? |
We could add a query param
Is the
Yes, but would like to wire that to a query param as well (or use the
That's not a question in my direction I guess :-) |
That would be great.
I think a separate parameter would be fine. We can add both parameters hardcoded here https://github.com/owncloud/ocis/blob/08a8ed20c18a1d5344cec78c4f72e61bee71c878/services/frontend/pkg/revaconfig/config.go#L102-L112. But then they apply to all clients using the /app/open-with-web endpoint. |
I noticed issues on the [confidential] test instance when I edit documents:
@wkloucek Is there anything I should call on the server or in the web app's JS context to "close" the web app session? At the moment, the web view is just terminated, so there probably is also no event being sent to the web app's JS part. |
We had a bug on that instance that is now fixed. Could you please try again if you can reproduce this issue?
Just closing is sufficient. It will take a few seconds before OnlyOffice saves the file and closes it. In the meantime it is locked and therefore can not be opened. |
@wkloucek I can confirm that this issue no longer occurs. |
Story
As a client user I want to open a file in the Web Office directly from the context menu so that I can easily start collaborating with others
Specifics
@hosy @felix-schwarz
The text was updated successfully, but these errors were encountered: