Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guest users can have the same name #142

Closed
davitol opened this issue Aug 22, 2017 · 10 comments
Closed

Guest users can have the same name #142

davitol opened this issue Aug 22, 2017 · 10 comments

Comments

@davitol
Copy link
Contributor

davitol commented Aug 22, 2017

screen shot 2017-08-22 at 11 05 42

@pmaier1 Guest users with different email can have the same name in oC. Should we add a restriction in other to avoid it?

@davitol davitol added this to the triage milestone Aug 22, 2017
@pmaier1
Copy link
Contributor

pmaier1 commented Aug 30, 2017

This is a general problem. Every user can change the display name ('full name') to an existing one. You can't even say in the sharing dialog which one is the one you need. In my example (see screenshot) I created two users, "test2" and "test3" and changed their display names to "hallo".

screenshot from 2017-08-30 17-47-51

We therefore need a general solution for this. Options:

  • Restrict display names to be unique (not that nice IMO)
  • Add some other differentiator to the display name, e.g. mail address in parentheses -> Ana (x@y.tld); maybe only in the duplicate case?
  • Instead of display name show the user name in the duplicate case?
  • other ideas?

This is nothing guests-specific and needs a core ticket. Probably there already is one.

@PVince81 when time permits.

@PVince81
Copy link
Contributor

Raised here: owncloud/core#28979

@cdamken
Copy link

cdamken commented Oct 12, 2017

This is a general problem. Every user can change the display name ('full name') to an existing one. You can't even say in the sharing dialog which one is the one you need. In my example (see screenshot) I created two users, "test2" and "test3" and changed their display names to "hallo".

The administrator is able to block users to modify the Displayname
https://github.com/owncloud/core/blob/v10.0.3/config/config.sample.php#L179-L183

But there is still this bug: owncloud/core#27442

@PVince81
Copy link
Contributor

with the latest master you cannot specify a name any more, you create guests directly by email address. So this bug is obsolete on the guests side

@PVince81
Copy link
Contributor

Hmm right, the display name. Reopening.

@PVince81 PVince81 reopened this Oct 12, 2017
@PVince81
Copy link
Contributor

Hmm right, the display name. Reopening.

@pmaier1 pmaier1 modified the milestones: development, planned Oct 17, 2017
@pmaier1
Copy link
Contributor

pmaier1 commented Dec 13, 2017

Hmm right, the display name. Reopening.

This is solved with the "solution for indistinguishable display names" we introduced with 10.0.4, right?

@PVince81
Copy link
Contributor

Guests are able to set display names, so two guests could set the same name.

But if the admin set the new core option to always display the email address in the sharing autocomplete, then it will be possible to distinguish these users, yes.

@davitol
Copy link
Contributor Author

davitol commented Dec 13, 2017

A regular user and a guest user:

With tooltips

screen shot 2017-12-13 at 14 07 06

With the new option to display the email address

screen shot 2017-12-13 at 14 06 17

So IMHO it is fine to close the ticket. @pmaier1 @PVince81

@pmaier1
Copy link
Contributor

pmaier1 commented Dec 13, 2017

Assuming that the API response also contains the mail address if enabled I close this now. Please reopen if this is not the case. A general guest identifier like an icon or "(guest)" would still be very helpful but that's actually another topic.

@pmaier1 pmaier1 closed this as completed Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants