Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom groups should only be visible to members #93

Open
pmaier1 opened this issue Aug 24, 2017 · 6 comments
Open

Custom groups should only be visible to members #93

pmaier1 opened this issue Aug 24, 2017 · 6 comments

Comments

@pmaier1
Copy link
Contributor

pmaier1 commented Aug 24, 2017

Not sure why we made custom groups global (every user can share with all groups of an instance).
Somehow I find it odd in the meantime as you get to see groups to share with in the sharing dialog that you actually don't 'know' and where you can't see the member list. The only use case I could think of is that I am advised to share with such a group while not getting all the other shares the group has.

If there are other use cases where the current handling is better, please shout out!

Addition TBD: We could change the default to 'not global' (only members can share with the group) and add an option (checkbox) to make it global.

@PVince81
Copy link
Contributor

I think we didn't purposefully "made them global". This is a side effect of using the sharing API integration and group backend API integration way.

This is the first step anyway.

If you want to have custom groups non-global and specific to members, you need to tick the sharing checkbox "Restrict users to only share with users in their groups" and it should work already.

One trouble though is that the latter option is global to any group backend, not only the custom groups one. The idea we discussed before was to provide separate checkboxes, one for each group backend:

- restrict users to only share with users in their groups for the following group backends:
    - checkbox: local (local groups)
    - checkbox: LDAP
    - checkbox: customgroups 

@PVince81
Copy link
Contributor

additional note: the splitting of checkboxes proposed previously is a change that needs to be done in core, as it's part of the sharing logic.

@PVince81
Copy link
Contributor

@pmaier1 move to "planned" ?

@PVince81 PVince81 modified the milestones: planned, development Aug 24, 2017
@PVince81
Copy link
Contributor

Moving to planned as discussed with @pmaier1.

As soon as customgroups is released, rename "planned" to "development"

@PVince81 PVince81 modified the milestones: planned, development Nov 20, 2017
@pmaier1 pmaier1 modified the milestones: development, planned Nov 20, 2017
@pmaier1
Copy link
Contributor Author

pmaier1 commented Apr 13, 2018

We should give custom group admins some more flexiblity here by offering two options in regards of visibility: Public and Closed

  • Public CG: Visible (group list and members) to every user in oC. Sharable by every user in oC. Joining the group only via admin invites.
  • Closed CG: Only visible (group list and members) for group members. Sharable only by members. Joining the group only via admin invites.

@PVince81 PVince81 modified the milestones: development, triage Apr 24, 2018
@PVince81
Copy link
Contributor

p3 and triage, will need scheduling and assignment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants