Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create acceptance tests for occ migrations commands #39197

Closed
Tracked by #33051
kiranparajuli589 opened this issue Sep 9, 2021 · 2 comments · Fixed by #40094
Closed
Tracked by #33051

create acceptance tests for occ migrations commands #39197

kiranparajuli589 opened this issue Sep 9, 2021 · 2 comments · Fixed by #40094
Assignees
Labels

Comments

@kiranparajuli589
Copy link
Contributor

kiranparajuli589 commented Sep 9, 2021

From #33051

  • I'm actually not sure whether we can add acceptance tests for this command
  • If not the issue can be closed
  • if yes, please share some ideas

Ref:
migration commands docs

@kiranparajuli589 kiranparajuli589 changed the title create acceptance tests for occ migrations commands (might be more challenging) create acceptance tests for occ migrations commands Sep 9, 2021
@phil-davis
Copy link
Contributor

migrations:generate is a developer tool to help create new "migration" code templates.
migrations:execute and migrations:migrate are special commands. Normally a production system will never use there. occ upgrade will run all relevant migrations anyway. I guess these special commands allow developers to run a new migration individually, or re-run a migration in a "controlled" way on a production system.
I don't think it will be so easy to make sensible tests for those.

migrations:status is a helpful utility to see which migrations have been run. I just noticed a problem with it - issue #40084 and fixed by PR #40085

It would be good to have a test for migrations:status - just do ``migrations:status core` and check that all the output data items exist and have "reasonable" values.

@phil-davis
Copy link
Contributor

I put this into the current sprint, because it would be nice to have test coverage related to PR #40085
But no problem if it moves into the next QA sprint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants