Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] allow users to opt-out autocomplete in share dialog #34942

Merged
merged 1 commit into from
Apr 3, 2019

Conversation

karakayasemi
Copy link
Contributor

@karakayasemi karakayasemi commented Apr 1, 2019

Backport of #34862

Description

allow users to opt-out autocomplete in sharing dialog

Also, I made some changes to simplify adding a new config option to personal sharing panel.

Related Issue

https://github.com/owncloud/enterprise/issues/3142

Motivation and Context

some users do not want to be found via autocomplete

How Has This Been Tested?

Manually tested by applying the following steps:

  • Create a user test
  • Login with admin
  • Enable Allow username autocompletion in share dialog checkbox within the sharing admin panel
  • Login with test
  • Disable Allow finding you via autocomplete in share dialog from personal sharing panel with test user
  • As an admin, search tes keyword in share dialog, test should not be listed
  • Enable Allow finding you via autocomplete in share dialog from personal sharing panel with test user
  • As an admin, search tes keyword in share dialog, test should be listed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@karakayasemi karakayasemi self-assigned this Apr 1, 2019
@karakayasemi karakayasemi changed the title allow users to opt-out autocomplete in share dialog [stable10] allow users to opt-out autocomplete in share dialog Apr 1, 2019
@karakayasemi karakayasemi merged commit 09d1e52 into stable10 Apr 3, 2019
@delete-merged-branch delete-merged-branch bot deleted the backport-34862 branch April 3, 2019 15:23
@PVince81 PVince81 added this to the QA milestone Apr 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants