[stable10] Switch to shorten hostname in status.php #34469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a switch to the status.php to shorten the hostname to the relative domain name using the new 'use_server_shortname' option in the config.sample.php. Added test case which makes sure the hostname can be shorten (if the FQDN contains a dot which will be used as separator between node and domain). If the option 'use_relative_domain_name' is set to true in the configuration, we do not want to tell '\OCP\Util::getStatusInfo()' it is false.
9 tasks
Codecov Report
@@ Coverage Diff @@
## stable10 #34469 +/- ##
==============================================
+ Coverage 63.57% 63.58% +<.01%
- Complexity 19146 19148 +2
==============================================
Files 1265 1265
Lines 75314 75321 +7
Branches 1291 1291
==============================================
+ Hits 47884 47892 +8
+ Misses 27050 27049 -1
Partials 380 380
Continue to review full report at Codecov.
|
2 similar comments
Codecov Report
@@ Coverage Diff @@
## stable10 #34469 +/- ##
==============================================
+ Coverage 63.57% 63.58% +<.01%
- Complexity 19146 19148 +2
==============================================
Files 1265 1265
Lines 75314 75321 +7
Branches 1291 1291
==============================================
+ Hits 47884 47892 +8
+ Misses 27050 27049 -1
Partials 380 380
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## stable10 #34469 +/- ##
==============================================
+ Coverage 63.57% 63.58% +<.01%
- Complexity 19146 19148 +2
==============================================
Files 1265 1265
Lines 75314 75321 +7
Branches 1291 1291
==============================================
+ Hits 47884 47892 +8
+ Misses 27050 27049 -1
Partials 380 380
Continue to review full report at Codecov.
|
DeepDiver1975
approved these changes
Feb 14, 2019
delete-merged-branch
bot
deleted the
stable10-shorten-status-hostname
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squashed backport of #32425 to stable10