Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Center the logo and login fields #34057

Merged

Conversation

DeepDiver1975
Copy link
Member

Force constant vertical height for login box over all devices

backport #33375

Force constant vertical height for login box over all devices
@codecov
Copy link

codecov bot commented Jan 8, 2019

Codecov Report

Merging #34057 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #34057   +/-   ##
===========================================
  Coverage       63.56%   63.56%           
  Complexity      19109    19109           
===========================================
  Files            1264     1264           
  Lines           75147    75147           
  Branches         1286     1286           
===========================================
  Hits            47770    47770           
  Misses          27001    27001           
  Partials          376      376
Flag Coverage Δ Complexity Δ
#javascript 53.32% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.66% <ø> (ø) 19109 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a3c623...c189588. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Jan 8, 2019

Codecov Report

Merging #34057 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #34057   +/-   ##
===========================================
  Coverage       63.56%   63.56%           
  Complexity      19109    19109           
===========================================
  Files            1264     1264           
  Lines           75147    75147           
  Branches         1286     1286           
===========================================
  Hits            47770    47770           
  Misses          27001    27001           
  Partials          376      376
Flag Coverage Δ Complexity Δ
#javascript 53.32% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.66% <ø> (ø) 19109 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a3c623...c189588. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 8, 2019

Codecov Report

Merging #34057 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #34057   +/-   ##
===========================================
  Coverage       63.56%   63.56%           
  Complexity      19109    19109           
===========================================
  Files            1264     1264           
  Lines           75147    75147           
  Branches         1286     1286           
===========================================
  Hits            47770    47770           
  Misses          27001    27001           
  Partials          376      376
Flag Coverage Δ Complexity Δ
#javascript 53.32% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.66% <ø> (ø) 19109 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a3c623...c189588. Read the comment docs.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@phil-davis phil-davis merged commit cc3fb3c into stable10 Feb 7, 2019
@delete-merged-branch delete-merged-branch bot deleted the stable10-8ea715954635b962e79d248c0d8632cc1ff1a125 branch February 7, 2019 13:16
@PVince81 PVince81 added this to the QA milestone Apr 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants