Extend maintenance:repair to allow runtime repairs.

[tomneedham]

Right now repair steps can be executed whilst in production with occ maintenance:repair and relies on the individual repair step to protect itself from maintenance mode etc.

We could extend the maintenance:repair command to have a --runtime or --production command to run only those that can run in production without maintenance mode, and protect all others with a maintenance mode check.

cc @PVince81

[ownclouders]

GitMate.io thinks possibly related issues are #13281 (Repair step to clean up oc_properties), #14109 (apache should run without mod_dav), #25164 (Allow user specific maintenance mode), #31464 (File cache repair step detection should not run on every upgrade), and #30989 (Remove pagination from the repair step).

[tomneedham]

My bad, maintenance mode is enabeld by this command:

core/core/Command/Maintenance/Repair.php

Line 101 in 6b521b4

$this->config->setSystemValue('maintenance', true);

[PVince81]

Hmm, but this also means that the repair step will induce a maintenance mode and might surprise admins. We could either add a confirmation prompt or refuse to run if not in maintenance mode ?

[tomneedham]

Added initial stuff here - got hung up adding tests around \OC\Repair which doesn't use DI and has static stuff. 25921a0

[tomneedham]

We could either add a confirmation prompt or refuse to run if not in maintenance mode ?

I agree, prefer to fail if maintenance mode is no enabled and prompt. Right now it just does it.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.