Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public link share name length check is inaccurate #31157

Closed
PVince81 opened this issue Apr 17, 2018 · 2 comments
Closed

Public link share name length check is inaccurate #31157

PVince81 opened this issue Apr 17, 2018 · 2 comments

Comments

@PVince81
Copy link
Contributor

Steps

  1. Create a public link share
  2. Type in 64 characters and make sure there are special unicode characters like "ü"
  3. Save share

Expected

Share name is accepted

Actual

Share name rejected
image

Version

10.0.8 RC1

It seems the limit is 64 ASCII characters and when using unicode it would use more bytes in the database. Not sure what to do in this case as we cannot predict accurately how many characters would be allowed if all of them were unicode.

Maybe the PHP function used for the check needs to account for unicode characters as well, but if it does, will the database (all DB types) accept them despite the fact that a unicode character will use more bytes ? Something to try.

This issue is likely to happen for other columns as well.

@PVince81 PVince81 added Type:Bug p3-medium Normal priority labels Apr 17, 2018
@PVince81 PVince81 added this to the QA milestone Apr 17, 2018
@PVince81 PVince81 changed the title Public link share name length inaccurate Public link share name length check is inaccurate Apr 17, 2018
@ownclouders
Copy link
Contributor

GitMate.io thinks possibly related issues are #1074 (Public sharing and pretty URL), #15022 (Share link hangs), #18737 (share link problem), #20442 (Share link hidden), and #5689 (Moving folder changes public share link).

@felixboehm felixboehm modified the milestones: QA, development Apr 17, 2018
@PVince81 PVince81 modified the milestones: development, triage Apr 24, 2018
@PVince81 PVince81 modified the milestones: triage, maybe some day May 22, 2018
@stale
Copy link

stale bot commented Sep 21, 2021

This issue has been automatically closed.

@stale stale bot closed this as completed Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants