Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Themes getHTMLName not used for layout.*.php #30881

Closed
butonic opened this issue Mar 23, 2018 · 2 comments · Fixed by #30882
Closed

Themes getHTMLName not used for layout.*.php #30881

butonic opened this issue Mar 23, 2018 · 2 comments · Fixed by #30882
Labels
enhancement feature:theming p4-low Low priority status/STALE
Milestone
backlog

Comments

@butonic
Copy link
Member

butonic commented Mar 23, 2018

Admins want to add a link to the name that is shown next to the logo. Currently the themes getName is used (also for the basic auth realm) but we actually already have a getHTMLName that should be used in the layout.guest.php and layout.user.php files.
@butonic butonic self-assigned this Mar 23, 2018
@butonic butonic added this to the development milestone Mar 23, 2018
@ownclouders
Copy link
Contributor

GitMate.io thinks possibly related issues are #3209 (Theming), #6263 (layout.user.php code is not valid markup), #23762 (remote.php/dav is not working when using cURL), #19794 (Themed logo-wide.svg not used), and #16845 (Use a custom layout ?).

@butonic butonic mentioned this issue Mar 23, 2018
Merged
@PVince81 PVince81 modified the milestones: development, planned Apr 3, 2018
@felixboehm
Copy link
Contributor

@pmaier1 please add a priority

@butonic butonic added the p4-low Low priority label Apr 20, 2018
@PVince81 PVince81 modified the milestones: development, backlog Jul 24, 2018
@butonic butonic removed their assignment Feb 18, 2019
@karakayasemi karakayasemi mentioned this issue May 20, 2019
Merged
10 tasks
@butonic butonic mentioned this issue Jun 14, 2019
Merged
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement feature:theming p4-low Low priority status/STALE
Projects
None yet
Milestone
backlog
Development

Successfully merging a pull request may close this issue.

allow html in claim and use htmlname in layout owncloud/core
4 participants
@PVince81 @butonic @felixboehm @ownclouders