Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return false if the stat doesn't find the file #27859

Merged
merged 1 commit into from
May 15, 2017

Conversation

jvillafanez
Copy link
Member

Description

return false instead of throwing an exception if the file isn't found

Related Issue

https://github.com/owncloud/windows_network_drive/issues/99

Motivation and Context

The stat function might fail because the file doesn't exists. In this case, the expectation should be to return false instead throwing an exception

How Has This Been Tested?

Manually

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@PVince81 @DeepDiver1975

@jvillafanez jvillafanez added this to the 10.0.1 milestone May 11, 2017
@PVince81
Copy link
Contributor

Makes sense 👍

I'm surprised we didn't find this earlier.

@PVince81
Copy link
Contributor

please rebase to rerun the Jenkins lottery, you might win!

@felixboehm felixboehm added the p1-urgent Critical issue, need to consider hotfix with just that issue label May 11, 2017
@PVince81
Copy link
Contributor

Oracle...

@PVince81
Copy link
Contributor

please rebase again

@jvillafanez
Copy link
Member Author

rebased

@PVince81
Copy link
Contributor

Failure expected, see #27888

Merging

@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4 - To release p1-urgent Critical issue, need to consider hotfix with just that issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants