Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement search column in accounts table #27850

Closed
3 tasks done
tomneedham opened this issue May 10, 2017 · 2 comments
Closed
3 tasks done

Implement search column in accounts table #27850

tomneedham opened this issue May 10, 2017 · 2 comments

Comments

@tomneedham
Copy link
Contributor

tomneedham commented May 10, 2017

Steps to reproduce

  1. Setup LDAP
  2. Add custom search attributes
  3. Try to search for a sharee using these custom attributes

Expected behaviour

  • Find users based on these attributes

Actual behaviour

  • Only displayname is searched in accounts table currently

Motivation

owncloud/user_ldap#96

Proposal

  • Additional column in accounts table to provide additional search terms 'additional_search_terms'
  • User Manager search inspects email, displayname, user_id and additional_search_terms fields in DB
  • User backends can provide a string which is loaded into this column on insertion to the account table and on user:sync

Additionally, the search method would have config options to remove ability to search by email, by displayname, or by login/user_id as the admin desires.

Plan:

  • Add migration to add additional column to accounts table
  • Add backend capability to supply additional search attributes in string
  • Adjust usermanager find method to read additionally from the search strings
@tomneedham
Copy link
Contributor Author

#27906

@lock
Copy link

lock bot commented Aug 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants