Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting the active navigation entry to 'files_index' is so wrong ... #27843

Merged
merged 1 commit into from
May 9, 2017

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented May 9, 2017

Description

The app name of files should be files ... how magical ...

Related Issue

fixes #27839

How Has This Been Tested?

  • switch between files app and settings
  • choose different language to make sure translations work as well

Screenshots (if appropriate):

bildschirmfoto von 2017-05-09 15-31-22

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 DeepDiver1975 added this to the 10.0.1 milestone May 9, 2017
@davitol
Copy link
Contributor

davitol commented May 9, 2017

👍 WFM

@DeepDiver1975
Copy link
Member Author

@individual-it any idea why this is falling apart? https://travis-ci.org/owncloud/core/jobs/230361342 THX

@individual-it
Copy link
Member

some funny internal error ether on travis or saucelabs.
Restarting the job did fix it

@PVince81
Copy link
Contributor

PVince81 commented May 9, 2017

👍 code makes sense

@DeepDiver1975 DeepDiver1975 merged commit c6525b1 into master May 9, 2017
@DeepDiver1975 DeepDiver1975 deleted the fix-files-menu-name branch May 9, 2017 21:50
@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App title says "Apps" instead of "Files" for the files app
4 participants