Fix missing translation of built-in section names

[vidaren]

Description

Changed translation resource from 'core' to 'lib', because translation of section names was not happening even though the code does translate it here: https://github.com/owncloud/core/blob/master/lib/private/Settings/SettingsManager.php#L195

Related Issue

App provided sections with translations and icons? #27327

Motivation and Context

Translation of section names was not happening on the Settings page. See screenshot of Norwegian installation below.

How Has This Been Tested?

Tested in private installation. Manual regression testing:

• The modified translation resource is used exclusively for translating sections in SettingsManager.php. This works after the fix.
• The modified translation resource is passed to SecurityWarning.php to translate memcache names. This design was already broken before the fix, because those names are in the 'settings' resource, neither in 'core' nor 'lib'. I leave it to others to decide how this separate issue is best fixed.

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

EDIT: Corrected link to SecurityWarning.php.

[CLAassistant]

All committers have signed the CLA.

[DeepDiver1975]

👍

[DeepDiver1975]

@vidaren please sign the CLA - just click on the button above - thx

[vidaren]

CLA signed.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.