Share owner avatar position

[PVince81]

@owncloud/designers @rullzer shouldn't the avatar rather be left or was it decided to have it right on purpose ? Or a bug ?

[PVince81]

Also there's an empty space when sharing with groups, is it ok ?

[rullzer]

@PVince81 mmm on the right makes more sense indeed. I'm not sure why I did not put it there in the first place.

Aaah yes the spacing... It indeed looks weird now... It is there so they align better if you have it shared with a user. Should also be fixable. I'll have a look later.

[jancborchardt]

@rullzer no, the avatar should always be on the left of the name. Here the placeholder of »root« is placed wrongly.

And yeah, we should show a group-icon after all for groups. Then it will look less strangely indented when you only shared with a group.

[rullzer]

Ah sorry typo. I meant on the left.

[rullzer]

I have a branch where the avatar is to the left (trivial fix).
I still need to look into the avatars for groups and remote users... since there are a lot of edge cases.

I'll keep you up to date..

[jancborchardt]

@rullzer great stuff, thank you! :)

[PVince81]

We might need an icon/avatar as well for server to server shares (aka ownCloud federation):
There's currently an empty space there as well. (AFAIK we currently cannot download avatars from a remote server)

[jancborchardt]

Would be awesome if we can then. :) At least for people whom you already shared with in the past.

[PVince81]

Probably not in this ticket. I raised this one for that: #14564

[jancborchardt]

Great stuff, thanks!

[nickvergessen]

Could put it directly infront of the user/group name, just like the activity app does?