Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use appframework for preview system #13610

Closed
2 tasks
georgehrke opened this issue Jan 22, 2015 · 10 comments
Closed
2 tasks

use appframework for preview system #13610

georgehrke opened this issue Jan 22, 2015 · 10 comments

Comments

@georgehrke
Copy link
Contributor

georgehrke commented Jan 22, 2015

Migrate preview.png, etc ... to appframework.

Subtasks:

  • Add a proper previewController
  • Preview / Image Response types (require stream based responses)
@oparoz
Copy link
Contributor

oparoz commented Feb 19, 2015

How will this work when we have to call several methods one after the other? We can't make REST calls for that as it would hurt performance badly.

@georgehrke
Copy link
Contributor Author

@oparoz I'm not sure what you are referring to. What several methods do we have to call one after another?

@oparoz
Copy link
Contributor

oparoz commented Feb 19, 2015

A Typical sequence

isMimeSupported()
getPreview()
valid()
width()
height()
isCached()

It's currently useful to be able to get an object so that we can call these methods.
I guess all the returned values could be included in the reply we get from the controller, if that reply was to include the values of all the public methods.

Sometimes we also use

resource()

But I guess it could be a separate call and not be too problematic as long as the Image class stays in core.

@DeepDiver1975 DeepDiver1975 modified the milestones: 8.2-next, 8.1-current Mar 2, 2015
@oparoz
Copy link
Contributor

oparoz commented Apr 25, 2015

@PVince81
Copy link
Contributor

Move to 9.0 as we're past feature-freeze ?

@georgehrke
Copy link
Contributor Author

see #18675 (comment)

I guess we can close this issue.

@ghost
Copy link

ghost commented Sep 21, 2015

moved to 9.0

@ghost ghost modified the milestones: 9.0-next, 8.2-current Sep 21, 2015
@PVince81
Copy link
Contributor

Past feature freeze, move to 9.1

@PVince81 PVince81 modified the milestones: 9.1-next, 9.0-current Feb 11, 2016
@PVince81 PVince81 modified the milestones: 9.1-current, 9.2-next Jun 15, 2016
@PVince81 PVince81 removed this from the 9.2 milestone Oct 14, 2016
@PVince81 PVince81 modified the milestones: backlog, 9.2 Oct 14, 2016
@PVince81
Copy link
Contributor

obsolete by DAV preview route: #29319

@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants