From b010b733f6f99593d8129487652456739aa7bf95 Mon Sep 17 00:00:00 2001 From: Phil Davis Date: Tue, 11 Jun 2019 21:14:50 +0545 Subject: [PATCH] Do not specially handle case when shareWith is null in itShouldNotBePossibleToShareFileFolderUsingTheWebUI --- .../features/bootstrap/WebUISharingContext.php | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/tests/acceptance/features/bootstrap/WebUISharingContext.php b/tests/acceptance/features/bootstrap/WebUISharingContext.php index 5466fb2f5a19..301487fd23a3 100644 --- a/tests/acceptance/features/bootstrap/WebUISharingContext.php +++ b/tests/acceptance/features/bootstrap/WebUISharingContext.php @@ -1251,14 +1251,10 @@ public function itShouldNotBePossibleToShareFileFolderUsingTheWebUI( ); $sharingWasPossible = true; } catch (ElementNotFoundException $e) { - if ($shareWith === null) { - $shareWithText = ""; + if ($userOrGroup === "user") { + $shareWithText = $this->sharingDialog->userStringsToMatchAutoComplete($shareWith); } else { - if ($userOrGroup === "user") { - $shareWithText = $this->sharingDialog->userStringsToMatchAutoComplete($shareWith); - } else { - $shareWithText = $this->sharingDialog->groupStringsToMatchAutoComplete($shareWith); - } + $shareWithText = $this->sharingDialog->groupStringsToMatchAutoComplete($shareWith); } $possibleMessages = [ "could not find share-with-field",