Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user I do not want corrupted files to be kept or overwriting existing files #1840

Open
1 task done
davivel opened this issue Nov 23, 2016 · 4 comments
Open
1 task done

Comments

@davivel
Copy link
Contributor

davivel commented Nov 23, 2016

Checksums will be used for integrity validation.

This is a proof of concept for mobile, Android first. We need to see what's the impact in performance in low-end devices.

  • Client computes checksum and sends to server, server verifies it and throws error if mismatch
  • Server calculates checksum on upload and stores result in oc_filecache.checksums
  • Server calculates checksum on download (if none available) and stores result in oc_filecache.checksums at the end of the transfer
  • If a checksum is available already in oc_filecache, the server returns it in the headers of any download
  • Client verifies checksums on download, if specified in the headers
  • Dependency for deduplication

Backend (Core/API)

@davivel davivel added this to the 2.3.0 milestone Nov 23, 2016
@davivel davivel modified the milestones: 2.4.0, 2.3.0 Mar 9, 2017
@davivel davivel modified the milestones: backlog, 2.4.0 Apr 11, 2017
@davivel
Copy link
Contributor Author

davivel commented Apr 11, 2017

Sorry, but we need to drop issues from milestone 2.4.0 to get it out next to OC 10 server.

This time we'll move topics to backlog instead of directly to next release, so that we can schedule 2.5.0 properly.

@shashvat-kedia
Copy link
Contributor

@davigonz Can I work on this?

@davigonz
Copy link
Contributor

Can I work on this?

Sure @hannesa2 but we have things with more priority like #1015 and since you have worked on the same menu to include sorting option, you might find it easier to implement. There's already a PR opened about that => #1342 just in case you need something to look into.

@shashvat-kedia
Copy link
Contributor

@davigonz Alright I will work on that first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants