Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only cache dependencies once in drone, not for every drone build #756

Closed
individual-it opened this issue Aug 1, 2022 · 5 comments
Closed
Assignees

Comments

@individual-it
Copy link
Member

dependencies that come from an other repo and are pinned by id (e.g. ocis in web, web in ocis, oc10 test code in ocis, ...) should only be cached once and left there for other drone builds

when e.g. pulling web into ocis and building it we use a specific commit id, the result of that is currently cached only for that particular drone build, but should be cached also for other builds. For that don't use the drone-build id in the name of the cached file, so that other builds can find it

@individual-it individual-it changed the title only cache dependencies once in drone, not only for a drone build only cache dependencies once in drone, not for every drone build Aug 1, 2022
@grgprarup
Copy link

The issue is fixed by the PR owncloud/ocis#4309. So closing this issue.

@kiranparajuli589
Copy link

kiranparajuli589 commented Aug 22, 2022

TODO:

  • oCIS can be cached similary inside the owncloud-sdk

@individual-it
Copy link
Member Author

individual-it commented Aug 23, 2022

@kiranparajuli589 if we use the same path we should be able to reuse ocis that was build in other repos e.g. web

@kiranparajuli589
Copy link

@kiranparajuli589 if we use the same path we should be able to reuse ocis that was build in other repos e.g. web

yes sure, I will try to implement that way.

@kiranparajuli589
Copy link

web and owncloud-sdk ci are now using the oCIS cache from the same location.
Cache is shared if both repos are looking for the oCIS binary of the same commit ID

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants