Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event target is set to DocumentFragment instead of peer connection itself #182

Open
lyubovzvereva opened this issue May 8, 2019 · 1 comment

Comments

@lyubovzvereva
Copy link

We started to use adapter in our calls and faced an issue with Edge where we would get a DocumentFragment as a target for onNegotiationNeeded event. After digging into adapter's logic we discovered that rtcpeerconnection-shim does this explicitly https://github.com/otalk/rtcpeerconnection-shim/blob/master/rtcpeerconnection.js#L41.
We were wondering if there are reasons for such a thing?
P.S. we use peer connection from event to check the current state (signalingState, iceConnectionState) and then create an offer.
Thanks!

@fippo
Copy link
Member

fippo commented May 18, 2019

the reason was probably "this mimicks chrome behaviour" back in ... 2015.
Do you have a jsfiddle or code snippet showing the difference in behaviour?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants