Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong call to addIceCandidate({}) after timeout #140

Open
fippo opened this issue Jun 12, 2018 · 2 comments
Open

wrong call to addIceCandidate({}) after timeout #140

fippo opened this issue Jun 12, 2018 · 2 comments

Comments

@fippo
Copy link
Member

fippo commented Jun 12, 2018

https://jsfiddle.net/qg0njd1s/
apparently runs into the 4 second timeout that tries to run addIceCandidate({})
This should not happen as the SDP has end-of-candidates.

Not very common but would be good to avoid.

@fippo
Copy link
Member Author

fippo commented Sep 21, 2018

the reason this goes wrong is that the 4 second timeout is started in setRemoteDescription but the ice transport is only started in SLD. The right thing is (imo) to move the timeout to where the ice transport is started.

@fippo
Copy link
Member Author

fippo commented Sep 21, 2018

moving this to a function called on start would be eas but the test mock is not complex enough and goes to complete when there is a remote candidate -- instead of waiting for addRemoteCandidate({})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant