Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various minor versioning related tweaks #2204

Merged
merged 2 commits into from
Sep 30, 2020

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Sep 25, 2020

commit 75342035d5902f299be53d7b541724407463d62c
Date:   Fri Sep 25 14:59:45 2020 -0400

    Makefile-libostree.am: Uncomment BUILDOPT_IS_DEVEL_BUILD conditional

    We shouldn't have to toggle the conditional itself during release
    builds. It should only evaluate to true during devel builds.

commit 68489f647832e3ab9f3856513e459a0cc296ef84
Date:   Fri Sep 25 15:01:09 2020 -0400

    lib: Minor versioning related fixes

    Fix/add the `Since` marker to the new static delta APIs, and update the
    symbol versioning templates/comments.

We shouldn't have to toggle the conditional itself during release
builds. It should only evaluate to true during devel builds.
Fix/add the `Since` marker to the new static delta APIs, and update the
symbol versioning templates/comments.
Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a5f9651 into ostreedev:master Sep 30, 2020
@jlebon jlebon deleted the pr/versioning-tweaks branch April 24, 2023 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants