Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OWNERS: add d4s to reviewers #2061

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

cgwalters
Copy link
Member

He did a lot of work on signing and will continue that.

He did a lot of work on signing and will continue that.
@jlebon
Copy link
Member

jlebon commented Apr 7, 2020

/approve

I guess we need to wait until @d4s accepts the org invite! :)

@cgwalters
Copy link
Member Author

Oops right, just sent that invite.

@d4s
Copy link
Member

d4s commented Apr 7, 2020

Thank you! Invite has been accepted.
Is there any other action from my side required?

@jlebon
Copy link
Member

jlebon commented Apr 7, 2020

I think that should do the trick!

/verify-owners
/lgtm

@jlebon
Copy link
Member

jlebon commented Apr 7, 2020

Is there any other action from my side required?

Hmm, I think the bot might require that your membership be public. Can you try changing that here? https://github.com/orgs/ostreedev/people?query=d4s

@d4s
Copy link
Member

d4s commented Apr 7, 2020

@jlebon done

@cgwalters
Copy link
Member Author

/refresh

@cgwalters
Copy link
Member Author

/verify-owners

@cgwalters
Copy link
Member Author

/lgtm

@openshift-ci-robot
Copy link
Collaborator

@cgwalters: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@d4s
Copy link
Member

d4s commented Apr 7, 2020

/lgtm
just testing ;)

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, d4s, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e88835e into ostreedev:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants