lib/repo-pull: fix GPG check while pulling remote #2060
Conversation
If GPG support is disabled in a build time we should to check if any of options "gpg_verify" or "gpg_verify_summary" is set to TRUE instead of checking if they are passed via options while pulling from remote. Fixed the failure with assertion of `ostree find-remotes --pull --mirror` calling (`tests/test-pull-collections.sh`) if libostree has been compiled without GPG support. Signed-off-by: Denis Pynkin <denis.pynkin@collabora.com>
|
Hi @d4s. Thanks for your PR. I'm waiting for a ostreedev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Can one of the admins verify this patch?
|
|
/cc @cgwalters |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, d4s The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
If GPG support is disabled in a build time we should to check if any of
options "gpg_verify" or "gpg_verify_summary" is set to TRUE instead
of checking if they are passed via options while pulling from remote.
Fixed the failure with assertion of
ostree find-remotes --pull --mirrorcalling (
tests/test-pull-collections.sh) if libostree has been compiledwithout GPG support.