From d7c23c94339cadc9093390afb9bbcb3e01f88f09 Mon Sep 17 00:00:00 2001 From: Dave Banerjee Date: Thu, 20 Oct 2022 17:28:55 -0500 Subject: [PATCH] =?UTF-8?q?=20:book:=20Patch=20fix:=20updated=20makefile?= =?UTF-8?q?=20to=20include=20unit-test=20and=20unit-test-attestor=20and=20?= =?UTF-8?q?cont=E2=80=A6=20(#2366)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * updated makefile to include unit-test and unit-test-attestor and contributing doc to include e2e-pat Signed-off-by: Dave Banerjee * updated docs Signed-off-by: Dave Banerjee Signed-off-by: Dave Banerjee Co-authored-by: Dave Banerjee --- CONTRIBUTING.md | 6 +++++- Makefile | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 71c99e8c344..ca8ab5c0048 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -102,7 +102,11 @@ Following the targets that can be used to test your changes locally. | Command | Description | Is called in the CI? | | -------- | -------------------------------------------------- | -------------------- | | make all | Runs go test,golangci lint checks, fmt, go mod tidy| yes | -| make e2e | Runs e2e tests | yes | +| make e2e-pat | Runs e2e tests | yes | + +Make sure to signoff your commits before submitting a pull request. + +https://docs.pi-hole.net/guides/github/how-to-signoff/ ## Permission for GitHub personal access tokens diff --git a/Makefile b/Makefile index a36aa11b8ce..2cc9968b834 100644 --- a/Makefile +++ b/Makefile @@ -84,7 +84,7 @@ install: $(GOLANGCI_LINT) \ ##@ Build ################################## make all ################################### all: ## Runs build, test and verify -all-targets = build check-linter validate-docs add-projects validate-projects +all-targets = build unit-test unit-test-attestor check-linter validate-docs add-projects validate-projects .PHONY: all all-targets-update-dependencies $(all-targets) update-dependencies tree-status all-targets-update-dependencies: $(all-targets) | update-dependencies all: update-dependencies all-targets-update-dependencies tree-status