Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VBS use cubic meters instead of cubic centimeters #15

Closed
mabelzhang opened this issue Jul 13, 2021 · 0 comments
Closed

VBS use cubic meters instead of cubic centimeters #15

mabelzhang opened this issue Jul 13, 2021 · 0 comments
Assignees
@arjo129

Comments

@mabelzhang
Copy link
Collaborator

Per #48 (comment) and discussions on Slack, SI units are the preference by ROS/Gazebo convention, so let's change the cubic centimeter representation in the BuoyancyEngingPlugin to cubic meters.

Note that TethysCommPlugin is currently doing * 1000000 and / 1000000 to convert to cubic meters, and those need to be removed after this change.
@arjo129 arjo129 self-assigned this Jul 21, 2021
@arjo129 arjo129 closed this as completed Aug 4, 2021
@caguero caguero reopened this Aug 4, 2021
@caguero caguero closed this as completed Aug 4, 2021
@chapulina chapulina transferred this issue from another repository Nov 2, 2021
@caguero caguero mentioned this issue Nov 2, 2021
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arjo129 arjo129

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@arjo129 @caguero @mabelzhang