-
Notifications
You must be signed in to change notification settings - Fork 869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display fields by default for certain brand presets #7558
Comments
A lot of them don't have drive throughs. For instance the around 587 in Barnes & Noble locations. There's also Starbucks in Target and Safeway stores that don't have drive throughs. IMO it's better to let people add the tag themselves then there be an error rate of like 20 or 30 percent that will probably never be fixed. |
I'm not proposing to add The Cafe preset in iD doesn't have the Drive Through field as seen in the id-tagging-schema repo. It looks like a similar issue was opened a few months ago (#7030) where it was suggested the field be added directly to |
Oh, my bad. I assume that's something that is done on iD Editor or the id-tagging-schema's side. It's interesting Brian closed #7030 as completed instead of won't fix though 🤷♂️ Whatever the case, I guess Zol87 never followed it up on it. Honestly I thought there was already a field for it in iD Editor 😄 |
It's a good idea, and I'd like to be able to have it as part of the NSI dataset, but suggesting a preset like this is something that is controlled by the iD Editor itself via the id-tagging-schema, and only then for generic entries. From the NSI side, we could just create a
It's something we could aim for in NSI 7 #7387 |
For now, yeah I think its ok to nudge the id-tagging-schema project add the field. Right now my bandwidth is pretty limited, so I'd prefer to keep the changes really small. |
From the OSM US Slack:
The drive through field should also shown by default for the Starbucks preset as a significant amount of their locations have them (#7030)
Currently, the
ref
field is undermoreFields
for the Public Bookcase preset inid-tagging-schema
(as seen here) since it doesn't have a significant amount of usage (400 out of 16K public bookcases, or 2.5% have aref
tag). This means that the field isn't displayed by default and users will have to search for it in theAdd field
section:The same thing applies to the
drive_through
field and the Cafe preset (only 3K out of 500K cafes, or 0.73% have adrive_through
tag)While more usage is typically needed for fields to display by default, I believe having these fields shown by default for only certain brand presets would make sense for instances such as LFL and Starbucks.
The text was updated successfully, but these errors were encountered: