Display fields by default for certain brand presets

[arch0345]

From the OSM US Slack:

The reference code should be displayed by default when the LFL preset is selected. They're prominently featured on the website and plaque on the bookcase door which makes them easy to find and add.

The drive through field should also shown by default for the Starbucks preset as a significant amount of their locations have them (#7030)

Currently, the ref field is under moreFields for the Public Bookcase preset in id-tagging-schema (as seen here) since it doesn't have a significant amount of usage (400 out of 16K public bookcases, or 2.5% have a ref tag). This means that the field isn't displayed by default and users will have to search for it in the Add field section:

The same thing applies to the drive_through field and the Cafe preset (only 3K out of 500K cafes, or 0.73% have a drive_through tag)

While more usage is typically needed for fields to display by default, I believe having these fields shown by default for only certain brand presets would make sense for instances such as LFL and Starbucks.

[Adamant36]

The drive through field should also be added to the Starbucks preset as a significant amount of their locations have them.

A lot of them don't have drive throughs. For instance the around 587 in Barnes & Noble locations. There's also Starbucks in Target and Safeway stores that don't have drive throughs. IMO it's better to let people add the tag themselves then there be an error rate of like 20 or 30 percent that will probably never be fixed.

[arch0345]

I'm not proposing to add drive_though=yes to the entry itself, rather adding the Drive Through field to the preset:

The Cafe preset in iD doesn't have the Drive Through field as seen in the id-tagging-schema repo. It looks like a similar issue was opened a few months ago (#7030) where it was suggested the field be added directly to id-tagging-schema. I'll open a PR for this.

[Adamant36]

I'm not proposing to add drive_though=yes to the entry itself, rather adding the Drive Through field to the preset:

Oh, my bad. I assume that's something that is done on iD Editor or the id-tagging-schema's side. It's interesting Brian closed #7030 as completed instead of won't fix though 🤷‍♂️ Whatever the case, I guess Zol87 never followed it up on it. Honestly I thought there was already a field for it in iD Editor 😄

[UKChris-osm]

It's a good idea, and I'd like to be able to have it as part of the NSI dataset, but suggesting a preset like this is something that is controlled by the iD Editor itself via the id-tagging-schema, and only then for generic entries.

From the NSI side, we could just create a fields array (like matchNames) and populate it with field suggestions, but this wouldn't do anything unless iD (or the tagging scheme) were coded to recognise and honour the suggestions.

{
"displayName": "Starbucks",
"fields": ["drive_through"],
"id": "starbucks-e1ef51",
"locationSet": {"include": ["001"]},
"tags": {
"amenity": "cafe",
"brand": "Starbucks",
"brand:wikidata": "Q37158",
"cuisine": "coffee_shop",
"name": "Starbucks",
"official_name": "Starbucks Coffee",
"takeaway": "yes"
}
},

It's something we could aim for in NSI 7 #7387

[bhousel]

For now, yeah I think its ok to nudge the id-tagging-schema project add the field.
If they won't add it, we can still generate presets that include a field not included in the default preset.
We can do this in the dist_files.js script, though it is a bit annoying.

Right now my bandwidth is pretty limited, so I'd prefer to keep the changes really small.