Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple types per source #179

Open
bhousel opened this issue Aug 23, 2016 · 12 comments
Open

Multiple types per source #179

bhousel opened this issue Aug 23, 2016 · 12 comments

Comments

@bhousel
Copy link
Member

bhousel commented Aug 23, 2016

Right now we have the type property, which is one of "tms", "wms", "bing", "scanex".

It would be nice to have each source file include all of the supported types for that source, rather than duplicating sources.

e.g.

source_types: {
  tms: { /*stuff*/ },
  wms: { /*other stuff*/ }
}
@iandees
Copy link
Member

iandees commented Aug 23, 2016

That makes sense to me.

@simonpoole
Copy link
Contributor

IMHO a good idea, but not backwards compatible and given that the format isn't versioned simply changing it would not be nice (as with OSM I assume that we don't really know who is consuming the data, if anybody).

@tyrasd
Copy link
Member

tyrasd commented Aug 23, 2016

related discussion: #24

@bhousel
Copy link
Member Author

bhousel commented Aug 23, 2016

IMHO a good idea, but not backwards compatible and given that the format isn't versioned simply changing it would not be nice (as with OSM I assume that we don't really know who is consuming the data, if anybody).

after #168 versioning the project becomes automatic

@simonpoole
Copy link
Contributor

Well except that my fork will continue to use the old scripts etc.

@iandees
Copy link
Member

iandees commented Aug 23, 2016

How does switching to Node make versioning automatic?

@bhousel
Copy link
Member Author

bhousel commented Aug 23, 2016

How does switching to Node make versioning automatic?

We publish regular releases to npm and follow semver..

@iandees
Copy link
Member

iandees commented Aug 23, 2016

Gotcha. We can do that with Python, too, so I was checking if there was something else.

@simon04
Copy link
Contributor

simon04 commented Nov 14, 2016

JOSM uses the notion of mirrors, see https://josm.openstreetmap.de/changeset/7990/josm for the change in the XSD file, and https://josm.openstreetmap.de/wiki/Maps/Italy#SouthTyrolTopomap for a layer specified as wms+tms.

@grischard
Copy link
Collaborator

We also duplicate a lot of polygons - it would be good if we could define one geojson feature, then multiple sources per feature, then multiple types per source.

@tyrasd
Copy link
Member

tyrasd commented Feb 27, 2018

We also duplicate a lot of polygons

An alternative solution to that sub-problem would be to distribute the data (also) in the topojson format, which implicitly gets rid of duplicate outline segments.

@Marc-marc-marc
Copy link
Collaborator

Marc-marc-marc commented Mar 31, 2018

some layers also have mirror url for the same type (for ex a mirror done by a local chapter to use when upstream is down). it would also be usefull to have them in the same layer. this need to allow 2 url for with the same type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants