example/centos: qcow2 for x86 and aarch64 #209
Conversation
supakeen
force-pushed
the
example-centos-x86-qcow2
branch
from
64331ec
to
99cf4fc
Compare
Temporarily ignore any UUIDs in tests as they are generated in different order leading to manifest mismatches. Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
supakeen
force-pushed
the
example-centos-x86-qcow2
branch
2 times, most recently
from
a090004
to
ac5bc63
Compare
There was a problem hiding this comment.
Looks good in general. Couple of questions.
But I'd also like to have a nice git history here, I think it will become important to have good context in the future about what's going on here. It'd be nice to have a separate commit where test/data/images-ref/ are added with a commit message describing where they came from:
Generated using
./test/data/images-ref/gen-image-deffor test reference. In the future, these will be generated on-demand for testing as long as we need them.
It'd also be really nice if changes were broken down a bit by category, like one commit where the pipeline/build.yaml file is introduced and and the otk.include: "pipeline/build.yaml" is added to the two centos manifests. Then another commit for the image, etc.
I get this might be a bit cumbersome to split up now, but I also think it's valuable, so feel free do it as far as you think it can be done without it making too much work.
test/data/images-ref/centos/9/aarch64/qcow2/centos_9-aarch64-qcow2-empty.json
Outdated
Show resolved
Hide resolved
These files were not used. Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
Include the repositories from a shared file. Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
Include the gpg keys from a shared file. Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
Move partition table files to a subdirectory to be consistent with other bits. Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
Shareable build pipeline include. Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
Change the grub2 fragment to be per-architecture. Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
Share a (per-architecture) image pipeline. Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
Generated using `./test/data/images-ref/gen-image-def` for test reference. In the future, these will be generated on-demand for testing as long as we need them. Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
Don't duplicate the kargs. Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
supakeen
force-pushed
the
example-centos-x86-qcow2
branch
from
ac5bc63
to
972244e
Compare
|
@achilleas-k All commits have been split out separately. |
|
We had a chat on Google Meet and I've resolved the outstanding comments related to SELinux and test(ing|ability). |
Initial setup and dedup to build the rest on.