Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

composer: don't create RepoRegistry using reporegistry.New() #4378

Merged
merged 2 commits into from
Sep 23, 2024
Merged

composer: don't create RepoRegistry using reporegistry.New() #4378

merged 2 commits into from
Sep 23, 2024

Commits on Sep 23, 2024

  1. composer: don't create RepoRegistry using reporegistry.New() 

    The `reporegistry.New()` has been enhanced to return an error, in case
there were no repositories loaded. This was to fix the situation in many
unit tests, which were previously not loading any repositories and
silently not running any tests.

This however broke our SaaS deployment, where we actually do not
configure any repositories on the filesystem. As a result,
osbuild-composer started to fail on it.

Workaround this situation in osbuild-composer by reverting to the old
behavior by loading the repo configs separately and then using the
loaded repos (which could be empty map) to initialize the RepoRegistry.

Signed-off-by: Tomáš Hozza <thozza@redhat.com>
    @thozza
    thozza committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    4d87212 View commit details
    Browse the repository at this point in the history

  2. provision.sh: ensure no repositories in the Service scenario 

    In the Service scenario, we should be testing that osbuild-composer
works fine, without any repository configurations being present on the
filesystem.

Signed-off-by: Tomáš Hozza <thozza@redhat.com>
    @thozza
    thozza committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    12963ea View commit details
    Browse the repository at this point in the history