Add installer customizations to blueprints and cloud API (HMS-1161) #4005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
vsphere failure is a known issue (server down). |
bcl
previously approved these changes
Mar 13, 2024
ondrejbudai
previously approved these changes
Mar 14, 2024
achilleas-k
force-pushed
the
unattended-iso
branch
from
e82335b
to
3b49dbe
Compare
|
@mcattamoredhat pointed out an issue with the kickstart injection in the ostree-ng test. Fixed now. |
bcl
previously approved these changes
Mar 14, 2024
achilleas-k
force-pushed
the
unattended-iso
branch
from
3b49dbe
to
79c297a
Compare
achilleas-k
force-pushed
the
unattended-iso
branch
from
79c297a
to
74d81b4
Compare
|
@ondrejbudai Can I get a quick re-approval and get this merged? The only change since the previous approvals was the test fix (and a rebase). |
ondrejbudai
previously approved these changes
Mar 18, 2024
Use the new installer customizations to build and boot an unattended installation and add the users to the sudoers with NOPASSWD enabled. This is added both to he base installer test (installers.sh) and the ostree test (ostree-ng.sh). For the ostree test, we keep the mkksiso step to retain the remote configuration change. The modksiso() function is changed to explicitly read the osbuild.ks file since we don't want to modify the osbuild-base.ks file and we want to ensure that the kernel command line argument points to the osbuild.ks file.
Adding both as a traditional compose request customization and in the new blueprint customizations.
Nightly pipelines test against older osbuild-composer versions so we need to still modify the kickstart file until the feature reaches the nightly composes.
achilleas-k
force-pushed
the
unattended-iso
branch
from
57b8d8e
to
fc04a6c
Compare
Again! |
achilleas-k
added a commit
to osbuild/osbuild.github.io
that referenced
this pull request
Apr 23, 2024
Describe the new installer customizations introduced into osbuild-composer in osbuild/osbuild-composer#4005.
ondrejbudai
pushed a commit
to osbuild/osbuild.github.io
that referenced
this pull request
Apr 24, 2024
Describe the new installer customizations introduced into osbuild-composer in osbuild/osbuild-composer#4005.
achilleas-k
added a commit
to osbuild/osbuild.github.io
that referenced
this pull request
Apr 24, 2024
Describe the new installer customizations introduced into osbuild-composer in osbuild/osbuild-composer#4005.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the osbuild/images dependency and exposes the new installer customizations in the blueprint and the cloud API.
Relevant osbuild/images PRs:
The kickstart injection in the installer test had been removed and we now use the new options to create an unattended ISO. In the edge installer test (
ostree-ng.sh), we keep the mkksiso call to add the ostree remote fix, but remove all the parts covered by our new customizations.This pull request includes: