From dd36fce63c7089388f3728bf310fc7f051924f41 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1=C5=A1=20Hozza?= Date: Mon, 3 Oct 2022 14:31:40 +0200 Subject: [PATCH] worker/gcp: return error if job doesn't specify object key The object key is required in order to upload the image to GCP. Return an error if it is not set. --- cmd/osbuild-worker/jobimpl-osbuild.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/cmd/osbuild-worker/jobimpl-osbuild.go b/cmd/osbuild-worker/jobimpl-osbuild.go index adb920a186..5747c97bbd 100644 --- a/cmd/osbuild-worker/jobimpl-osbuild.go +++ b/cmd/osbuild-worker/jobimpl-osbuild.go @@ -580,6 +580,11 @@ func (impl *OSBuildJobImpl) Run(job worker.Job) error { break } + if targetOptions.Object == "" { + targetResult.TargetError = clienterrors.WorkerClientError(clienterrors.ErrorInvalidTargetConfig, "No GCP object key provided", nil) + break + } + bucket := targetOptions.Bucket if bucket == "" { bucket = impl.GCPConfig.Bucket