gen-manifests: create predictable version/release numbers in mockDepsolve #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
added a commit
to mvo5/osbuild-otk
that referenced
this pull request
Sep 16, 2024
The `grub2` fragment require the release/version/arch of the kernel package. Add them to the external so that they can be used inside otk files. Also tweak the mocks to follow osbuild/images#937 so that we have predictable but non-empty version/release numbers.
mvo5
added a commit
to mvo5/osbuild-otk
that referenced
this pull request
Sep 16, 2024
This commit updates the `fragment/grub2.yaml` to use the newly
available `packages.os.const.kernel.{release,version,arch}` so
that this works for real data and not just the `0-0.noarch` mocks.
Also update the reference manifests based on
osbuild/images#937
mvo5
added a commit
to mvo5/osbuild-otk
that referenced
this pull request
Sep 16, 2024
The `grub2` fragment require the release/version/arch of the kernel package. Add them to the external so that they can be used inside otk files. Also tweak the mocks to follow osbuild/images#937 so that we have predictable but non-empty version/release numbers.
mvo5
added a commit
to mvo5/osbuild-otk
that referenced
this pull request
Sep 16, 2024
This commit updates the `fragment/grub2.yaml` to use the newly
available `packages.os.const.kernel.{release,version,arch}` so
that this works for real data and not just the `0-0.noarch` mocks.
Also update the reference manifests based on
osbuild/images#937
supakeen
reviewed
Sep 16, 2024
…olve The current code will only generate "0" version numbers for packages and releases. This limits the usefulness of this mock in the tests for otk. Instead generate predictable but (mostly) non-zero numbers based on the modulo of the first and second char of the pkgname.
mvo5
force-pushed
the
create-predictable-version-numbers-in-mock
branch
from
9a4ac5f
to
3b4b3a7
Compare
mvo5
changed the title
mvo5
added a commit
to mvo5/osbuild-otk
that referenced
this pull request
Sep 24, 2024
This commit fixes the grub2 fragments that require changing after: osbuild/images#943 osbuild/images#937 We now create predictable versions/release for fake kernels and also include the architecture.
mvo5
added a commit
to mvo5/osbuild-otk
that referenced
this pull request
Sep 24, 2024
This commit fixes the grub2 fragments that require changing after: osbuild/images#943 osbuild/images#937 We now create predictable versions/release for fake kernels and also include the architecture.
mvo5
added a commit
to mvo5/osbuild-otk
that referenced
this pull request
Sep 24, 2024
This commit fixes the grub2 fragments that require changing after: osbuild/images#943 osbuild/images#937 We now create predictable versions/release for fake kernels and also include the architecture.
github-merge-queue bot
pushed a commit
to osbuild/otk
that referenced
this pull request
Sep 24, 2024
This commit fixes the grub2 fragments that require changing after: osbuild/images#943 osbuild/images#937 We now create predictable versions/release for fake kernels and also include the architecture.
mvo5
added a commit
to mvo5/osbuild-otk
that referenced
this pull request
Sep 25, 2024
This commit updates the generated mock meta-data from the `gen_depsolve_dnf4` to follow the `gen_manifests` updates from the images library, most notably: osbuild/images#937 osbuild/images#943
mvo5
added a commit
to mvo5/osbuild-otk
that referenced
this pull request
Sep 25, 2024
This commit updates the generated mock meta-data from the `gen_depsolve_dnf4` to follow the `gen_manifests` updates from the images library, most notably: osbuild/images#937 osbuild/images#943
mvo5
added a commit
to mvo5/osbuild-otk
that referenced
this pull request
Sep 26, 2024
This commit updates the generated mock meta-data from the `gen_depsolve_dnf4` to follow the `gen_manifests` updates from the images library, most notably: osbuild/images#937 osbuild/images#943
github-merge-queue bot
pushed a commit
to osbuild/otk
that referenced
this pull request
Sep 26, 2024
This commit updates the generated mock meta-data from the `gen_depsolve_dnf4` to follow the `gen_manifests` updates from the images library, most notably: osbuild/images#937 osbuild/images#943
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code will only generate "0" version numbers for packages and releases. This limits the usefulness of this mock in the tests for otk. Instead generate predictable but (mostly) non-zero numbers based on the modulo of the first and second char of the pkgname.
Useful for e.g. osbuild/otk#196 as it will ensure that the
fragment/grub2.yamlactually changes depending on the kernel name.