Revert "manifest: switch to halt --eject to avoid auto-reboot"
#915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 002c25d.
achilleas-k
approved these changes
Sep 9, 2024
mvo5
added a commit
to mvo5/bootc-image-builder
that referenced
this pull request
Sep 9, 2024
There was a regression in the "images" library that PR#915 [0] fixes. [0] osbuild/images#915
mvo5
added a commit
to mvo5/bootc-image-builder
that referenced
this pull request
Sep 9, 2024
There was a regression in the "images" library for building the bootc anaconda-iso that PR#915 [0] fixes. [0] osbuild/images#915
mvo5
added a commit
to mvo5/bootc-image-builder
that referenced
this pull request
Sep 9, 2024
There was a regression in the "images" library for building the bootc anaconda-iso that PR#915 [0] fixes. [0] osbuild/images#915
mvo5
added a commit
to mvo5/bootc-image-builder
that referenced
this pull request
Sep 9, 2024
There was a regression in the "images" library for building the bootc anaconda-iso that PR#915 [0] fixes. [0] osbuild/images#915
github-merge-queue bot
pushed a commit
to osbuild/bootc-image-builder
that referenced
this pull request
Sep 10, 2024
There was a regression in the "images" library for building the bootc anaconda-iso that PR#915 [0] fixes. [0] osbuild/images#915
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 002c25d.
We are currently seeing issue with the
bootc-image-builderiso tests, this maybe the culprit.[edit: with this revert it seems like the error that we are curerntly seeing goes away so we need to look at this again - but let's first revert to unblock images]