Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image: add vhd/vpc support to BootcDiskImage #909

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

mvo5
Copy link
Contributor

@mvo5 mvo5 commented Sep 5, 2024

This will help konflux to build azure/vhd images directly.

The corresponding bib change can be found in osbuild/bootc-image-builder#634.

Closes: osbuild/bootc-image-builder#132

mvo5 added a commit to mvo5/bootc-image-builder that referenced this pull request Sep 5, 2024
This is the coresponding change to the images PR [0] that adds
support to build `vhd` type images directly via bib.

[0] osbuild/images#909
mvo5 added a commit to mvo5/bootc-image-builder that referenced this pull request Sep 5, 2024
This is the coresponding change to the images PR [0] that adds
support to build `vhd` type images directly via bib.

[0] osbuild/images#909
mvo5 added a commit to mvo5/bootc-image-builder that referenced this pull request Sep 5, 2024
This is the coresponding change to the images PR [0] that adds
support to build `vhd` type images directly via bib.

[0] osbuild/images#909
mvo5 added a commit to mvo5/bootc-image-builder that referenced this pull request Sep 5, 2024
This is the coresponding change to the images PR [0] that adds
support to build `vhd` type images directly via bib.

[0] osbuild/images#909
Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM(draft)

@mvo5 mvo5 force-pushed the add-vhd-to-bootc-disk branch 2 times, most recently from 2f38ebe to eb0ba66 Compare September 6, 2024 10:51
@mvo5 mvo5 marked this pull request as ready for review September 6, 2024 10:52
This will help konflux to build azure/vhd images directly.

Closes: osbuild/bootc-image-builder#132
@achilleas-k achilleas-k added this pull request to the merge queue Sep 6, 2024
Merged via the queue into osbuild:main with commit 7bfd9da Sep 6, 2024
19 checks passed
mvo5 added a commit to mvo5/bootc-image-builder that referenced this pull request Sep 9, 2024
This is the coresponding change to the images PR [0] that adds
support to build `vhd` type images directly via bib.

[0] osbuild/images#909
mvo5 added a commit to mvo5/bootc-image-builder that referenced this pull request Sep 9, 2024
This is the coresponding change to the images PR [0] that adds
support to build `vhd` type images directly via bib.

[0] osbuild/images#909
mvo5 added a commit to mvo5/bootc-image-builder that referenced this pull request Sep 9, 2024
This is the coresponding change to the images PR [0] that adds
support to build `vhd` type images directly via bib.

[0] osbuild/images#909
mvo5 added a commit to mvo5/bootc-image-builder that referenced this pull request Sep 10, 2024
This is the coresponding change to the images PR [0] that adds
support to build `vhd` type images directly via bib.

[0] osbuild/images#909
mvo5 added a commit to mvo5/bootc-image-builder that referenced this pull request Sep 10, 2024
This is the coresponding change to the images PR [0] that adds
support to build `vhd` type images directly via bib.

[0] osbuild/images#909
github-merge-queue bot pushed a commit to osbuild/bootc-image-builder that referenced this pull request Sep 10, 2024
This is the coresponding change to the images PR [0] that adds
support to build `vhd` type images directly via bib.

[0] osbuild/images#909
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for .vhd / Azure
2 participants