Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blueprint: fix filesystem customization parsing #885

Merged
merged 3 commits into from
Sep 2, 2024
Merged

blueprint: fix filesystem customization parsing #885

merged 3 commits into from
Sep 2, 2024

Commits on Aug 30, 2024

  1. blueprint: fix parsing filesystem minsize 

    The toml tag and bootc-image-builder uses the new key "minsize", but the
custom unmarshaller still referred to the old "size" key. Unfortunately,
the test was also wrong.

This commit changes both the unmarshaller and the test to use new
"minsize" key, hopefully finally bringing sanity to this code.

I also changed some require.Nil calls to require.NoError to make the
test results more readable if these tests fail.
    @ondrejbudai
    ondrejbudai committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    1cf1ea0 View commit details
    Browse the repository at this point in the history

  2. blueprint: make json filesystem parsing consistent with the toml one 

    There's no functional change except for a minor adjustements of an
error. I just made sure that everything refers to minsize instead of
size. Also, I removed a comment that mentioned that the keys are called
differently in json than in toml, but that's no longer true. See e.g.
the previous commit.
    @ondrejbudai
    ondrejbudai committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    fa0aff3 View commit details
    Browse the repository at this point in the history

  3. blueprint: add unhappy tests for filesystem unmarshallers

    @ondrejbudai
    ondrejbudai committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    5faf0d4 View commit details
    Browse the repository at this point in the history