Rename image(s) cmd flags to type(s) and add checkpoints to build #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I definitely don't do this /s |
Oh right, forgot about that one. Thanks! |
The build command requires the --image flag to specify the image type to build. Similarly, gen-manifests and list-images commands support specifying image types using the --images flag. These were originally named this way because image-type(s) felt too long. Rename them to --type and --types. This is less ambiguous and matches the flag name chosen by bootc-image-builder. The cmds are development and testing tools, so there is no need to keep the old and deprecate it for a backwards compatible and smooth transition.
Update the flags wherever they're used in our test setup.
Support specifying checkpoints when running cmd/build.
achilleas-k
force-pushed
the
fiddling/cmds
branch
from
e5758c3
to
76694cc
Compare
|
Changed list-images too and updated the commit message. |
thozza
approved these changes
Aug 28, 2024
|
Would it make sense to return an error or deprecation warning for people using the "old" argument? |
I considered it but it's just too much fluff for something that's only used internally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a couple of changes I've been fiddling with while working on other stuff.
--typeis a better name for the image type flag than--imageforcmd/buildand the same for the plural form forcmd/gen-manifestsandcmd/list-images.--checkpointsflag that gets passed down to osbuild.We might add an
--osbuild-optionsflag instead and use that to pass stuff down to osbuild in the future, but let's keep this short for now.